opencode-mobile/.tasks/10/review.md at 32f7af4e11c7163ec01154a3b36aa68e70335c68

Files

Den 32f7af4e11 fix(sessions): recover home-scoped list after fresh connect

* fix(sessions): use active connection client directly, remove roots filter

Root cause A: loadSessions was calling clientForDirectory(serverHome) which
scoped the session list to /home/azureuser — a different project than the
server's active CWD. Sessions in the current project (e.g. opencode-mobile)
were never returned.

Root cause B: roots:true filtered out sessions that have a parentID (sub-task /
AUTO-REVIEW sessions), hiding valid sessions from the list.

Fix: use connState.client directly (the connection's active directory) and drop
the roots filter so all sessions for that project are visible.

Also adds a verify_session_list CUA smoke scenario that navigates back to the
sessions tab after creating a session and asserts the list is non-empty —
covering the regression path that was previously untested.

* fix(sessions): fetch serverHome in addConnection so loadSessions shows correct sessions

Root cause: addConnection() built the HTTP client but never fetched serverHome
(only loadConnections and setActiveConnection did). When the user adds a new
connection (fresh install / first sign-in), serverHome = null, so loadSessions
fell through to connState.client (the server's CWD). On this dev server the CWD
is the deploy directory — 11 old May-19 sessions that are not the user's recent
work sessions.

Fix: addConnection now fetches currentProject + serverHome via the same
Promise.all as setActiveConnection, before calling set(). This ensures
loadSessions immediately uses clientForDirectory(serverHome) → the global
project → the user's actual recent parent sessions.

Also adds --opencode-url flag to the CUA smoke script, which appends a
connect_and_verify_sessions scenario that reproduces the regression:
python scripts/android-cua-smoke.py --opencode-url http://100.108.64.76:4096

* fix(sessions): recover home scope after fresh connect

Resolve stale deploy-only session list by recovering server home during first load and keeping regression coverage in default Android CUA smoke and CI.

* chore(release): bump version to 0.4.0

2026-05-26 19:50:17 -07:00

923 B

Raw Blame History

Final Phase 5b review completed for updated files:

src/stores/sessions.ts: Session listing logic keeps the validated scope behavior (serverHome fallback when connection directory is unset, roots: true, bounded list fetch), aligning with design goals and Done Criteria Task 2.
scripts/android-cua-smoke.py: Connect-and-verify regression scenario is now included in default smoke runs (unless explicitly skipped), with optional --opencode-url/OPENCODE_URL support; parser/execution validity confirmed via python3 -m py_compile.
.github/workflows/cua-smoke.yml: CI executes the smoke script in default mode with OPENCODE_URL set, so the connect-then-sessions regression path is exercised in automation, satisfying Done Criteria Task 4 coverage intent.
Validation checks run: python3 -m py_compile scripts/android-cua-smoke.py and npx tsc --noEmit both pass.

No blocking findings. VERDICT: pass

923 B Raw Blame History

923 B

Raw Blame History