Files
opencode-mobile/app/connection/[id].tsx
Den f86265aa7c fix(security): re-lock biometric app-lock on background; persist edited password (#125)
Two issues from a security review of the credential/auth path (the review also
verified the fundamentals are solid — passwords in SecureStore, Sentry/analytics/
Chatwoot all scrub secrets).

1. HIGH: biometric app-lock never re-armed. authenticate() sets isAuthenticated
   =true once at cold start and lock() was never called (no AppState listener) —
   so 'Require Biometric to Open' was fully bypassable: after one unlock, anyone
   with brief physical access could reopen a backgrounded app straight into
   session history and connection details for the life of the JS process. Now an
   AppState 'background' listener calls lock() when the toggle is on. Fires on
   'background' only, so the biometric prompt / app switcher (transient
   'inactive') don't cause spurious re-locks.

2. Editing a connection's password did nothing: the edit screen's password field
   was never passed to updateConnection, which never wrote PASSWORDS_PREFIX — so
   a user rotating a server password silently kept using the old one. updateConnection
   now takes an optional password and writes it to SecureStore (blank = keep
   existing, since the field loads empty).

typecheck clean, 187/187 tests.


Claude-Session: https://claude.ai/code/session_01T12AhSnQVrSxNnvwfCx2z6

Co-authored-by: engineer <engineer@macbookpro.lan>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-18 08:49:42 -07:00

465 lines
13 KiB
TypeScript

import { useEffect, useState } from "react"
import {
View,
Text,
TextInput,
TouchableOpacity,
ScrollView,
StyleSheet,
useColorScheme,
ActivityIndicator,
Alert,
} from "react-native"
import { router, useLocalSearchParams } from "expo-router"
import { Ionicons } from "@expo/vector-icons"
import { useTranslation } from "react-i18next"
import { useConnections } from "../../src/stores/connections"
import { useEvents } from "../../src/stores/events"
import type { ConnectionType } from "../../src/lib/types"
import { probeConnection, shareReport } from "../../src/lib/diagnostics"
import { captureDiagnostic } from "../../src/lib/sentry"
import { parseUrl } from "../../src/lib/diagnostics-classify"
// labelKey (not literal text): this is a module-level constant evaluated
// before i18next is guaranteed ready, so the label is resolved with t() at
// render time — same pattern as categoryMeta in src/lib/notifications.ts.
const CONNECTION_TYPES: Array<{
type: ConnectionType
labelKey: string
icon: keyof typeof Ionicons.glyphMap
}> = [
{ type: "local", labelKey: "connection.shared.types.local", icon: "wifi" },
{ type: "tunnel", labelKey: "connection.shared.types.tunnel", icon: "globe" },
{ type: "cloud", labelKey: "connection.shared.types.cloud", icon: "cloud" },
]
export default function EditConnectionScreen() {
const { id } = useLocalSearchParams<{ id: string }>()
const colorScheme = useColorScheme()
const isDark = colorScheme === "dark"
const { t } = useTranslation()
const { connections, updateConnection, removeConnection, testConnection } = useConnections()
const connection = connections.find((c) => c.id === id)
const [type, setType] = useState<ConnectionType>(connection?.type || "local")
const [name, setName] = useState(connection?.name || "")
const [url, setUrl] = useState(connection?.url || "")
const [directory, setDirectory] = useState(connection?.directory || "")
const [username, setUsername] = useState(connection?.username || "")
const [password, setPassword] = useState("")
const [isTesting, setIsTesting] = useState(false)
const [isSaving, setIsSaving] = useState(false)
useEffect(() => {
if (connection) {
setType(connection.type)
setName(connection.name)
setUrl(connection.url)
setDirectory(connection.directory || "")
setUsername(connection.username || "")
}
}, [connection])
if (!connection) {
return (
<View style={[styles.container, isDark && styles.containerDark, styles.center]}>
<Text style={[styles.errorText, isDark && styles.textDark]}>{t("connection.edit.notFound")}</Text>
</View>
)
}
const handleTest = async () => {
if (!url.trim()) {
Alert.alert(t("common.error"), t("connection.shared.alerts.enterUrl"))
return
}
if (!parseUrl(url).valid) {
Alert.alert(t("connection.shared.alerts.invalidUrlTitle"), t("connection.shared.alerts.invalidUrlMessage"))
return
}
setIsTesting(true)
const result = await testConnection(
{
id: connection.id,
name: name || "Test",
type,
url: url.trim(),
directory: directory.trim() || undefined,
username: username.trim() || undefined,
},
"edit_test",
password || undefined,
)
if (result.ok) {
setIsTesting(false)
Alert.alert(t("connection.edit.alerts.successTitle"), t("connection.edit.alerts.successMessage"))
return
}
// Failed: run active diagnostics, capture to Sentry, offer a shareable report.
const report = await probeConnection(
url.trim(),
username.trim() && password ? { username: username.trim(), password } : undefined,
)
captureDiagnostic(report)
setIsTesting(false)
Alert.alert(
t("connection.shared.alerts.connectionFailedTitle"),
t("connection.edit.alerts.connectionFailedMessage", {
summary: report.summary,
detail: result.error || t("connection.edit.alerts.noDetail"),
}),
[
{ text: t("common.ok"), style: "cancel" },
{ text: t("common.shareReport"), onPress: () => shareReport(report) },
],
)
}
const handleSave = async () => {
if (!name.trim()) {
Alert.alert(t("common.error"), t("connection.shared.alerts.enterName"))
return
}
if (!url.trim()) {
Alert.alert(t("common.error"), t("connection.shared.alerts.enterUrl"))
return
}
if (!parseUrl(url).valid) {
Alert.alert(t("connection.shared.alerts.invalidUrlTitle"), t("connection.shared.alerts.invalidUrlMessage"))
return
}
setIsSaving(true)
await updateConnection(
connection.id,
{
name: name.trim(),
type,
url: url.trim(),
directory: directory.trim() || undefined,
username: username.trim() || undefined,
},
// Empty = keep existing password (the field loads blank); a typed value
// rotates it in SecureStore.
password || undefined,
)
// If this was the active connection, the SSE loop may have stopped
// retrying after a prior 401 (see events.ts) — reconnect now with the
// freshly saved credentials instead of leaving the user stuck until
// they relaunch the app.
if (useConnections.getState().activeConnection?.id === connection.id) {
useEvents.getState().connect()
}
setIsSaving(false)
router.back()
}
const handleDelete = () => {
Alert.alert(t("connection.edit.alerts.deleteTitle"), t("connection.edit.alerts.deleteMessage", { name: connection.name }), [
{ text: t("common.cancel"), style: "cancel" },
{
text: t("common.delete"),
style: "destructive",
onPress: async () => {
await removeConnection(connection.id)
router.back()
},
},
])
}
return (
<ScrollView
style={[styles.container, isDark && styles.containerDark]}
contentContainerStyle={styles.content}
keyboardShouldPersistTaps="handled"
>
{/* Connection Type */}
<Text style={[styles.label, isDark && styles.labelDark]}>{t("connection.shared.connectionType")}</Text>
<View style={styles.typeContainer}>
{CONNECTION_TYPES.map((opt) => (
<TouchableOpacity
key={opt.type}
style={[
styles.typeOption,
isDark && styles.typeOptionDark,
type === opt.type && styles.typeOptionSelected,
type === opt.type && isDark && styles.typeOptionSelectedDark,
]}
onPress={() => setType(opt.type)}
>
<Ionicons
name={opt.icon}
size={20}
color={type === opt.type ? (isDark ? "#0a0a0a" : "#ffffff") : isDark ? "#888888" : "#666666"}
/>
<Text
style={[
styles.typeLabel,
isDark && styles.textDark,
type === opt.type && styles.typeLabelSelected,
type === opt.type && isDark && styles.typeLabelSelectedDark,
]}
>
{t(opt.labelKey)}
</Text>
</TouchableOpacity>
))}
</View>
{/* Name */}
<Text style={[styles.label, isDark && styles.labelDark]}>{t("connection.shared.name")}</Text>
<TextInput
style={[styles.input, isDark && styles.inputDark]}
placeholder={t("connection.shared.namePlaceholder")}
placeholderTextColor={isDark ? "#666666" : "#999999"}
value={name}
onChangeText={setName}
/>
{/* URL */}
<Text style={[styles.label, isDark && styles.labelDark]}>{t("connection.shared.serverUrl")}</Text>
<TextInput
style={[styles.input, isDark && styles.inputDark]}
placeholder="http://192.168.1.100:4096"
placeholderTextColor={isDark ? "#666666" : "#999999"}
value={url}
onChangeText={setUrl}
autoCapitalize="none"
autoCorrect={false}
keyboardType="url"
/>
{/* Directory */}
<Text style={[styles.label, isDark && styles.labelDark]}>{t("connection.shared.directoryOptional")}</Text>
<TextInput
style={[styles.input, isDark && styles.inputDark]}
placeholder="/path/to/project"
placeholderTextColor={isDark ? "#666666" : "#999999"}
value={directory}
onChangeText={setDirectory}
autoCapitalize="none"
autoCorrect={false}
/>
<Text style={[styles.hint, isDark && styles.hintDark]}>{t("connection.edit.directoryHint")}</Text>
{/* Auth */}
<Text style={[styles.sectionTitle, isDark && styles.textDark]}>{t("connection.shared.authentication")}</Text>
<Text style={[styles.label, isDark && styles.labelDark]}>{t("connection.shared.username")}</Text>
<TextInput
style={[styles.input, isDark && styles.inputDark]}
placeholder="admin"
placeholderTextColor={isDark ? "#666666" : "#999999"}
value={username}
onChangeText={setUsername}
autoCapitalize="none"
autoCorrect={false}
/>
<Text style={[styles.label, isDark && styles.labelDark]}>{t("connection.edit.passwordLabel")}</Text>
<TextInput
style={[styles.input, isDark && styles.inputDark]}
placeholder="••••••••"
placeholderTextColor={isDark ? "#666666" : "#999999"}
value={password}
onChangeText={setPassword}
secureTextEntry
/>
{/* Actions */}
<View style={styles.actions}>
<TouchableOpacity
style={[styles.testButton, isDark && styles.testButtonDark]}
onPress={handleTest}
disabled={isTesting}
>
{isTesting ? (
<ActivityIndicator size="small" color={isDark ? "#ffffff" : "#0a0a0a"} />
) : (
<>
<Ionicons name="pulse" size={20} color={isDark ? "#ffffff" : "#0a0a0a"} />
<Text style={[styles.testButtonText, isDark && styles.textDark]}>{t("connection.edit.testButton")}</Text>
</>
)}
</TouchableOpacity>
<TouchableOpacity
style={[styles.saveButton, isDark && styles.saveButtonDark]}
onPress={handleSave}
disabled={isSaving}
>
{isSaving ? (
<ActivityIndicator size="small" color={isDark ? "#0a0a0a" : "#ffffff"} />
) : (
<Text style={[styles.saveButtonText, isDark && styles.saveButtonTextDark]}>
{t("connection.edit.saveButton")}
</Text>
)}
</TouchableOpacity>
<TouchableOpacity style={styles.deleteButton} onPress={handleDelete}>
<Ionicons name="trash-outline" size={20} color="#ef4444" />
<Text style={styles.deleteButtonText}>{t("connection.edit.deleteButton")}</Text>
</TouchableOpacity>
</View>
</ScrollView>
)
}
const styles = StyleSheet.create({
container: {
flex: 1,
backgroundColor: "#ffffff",
},
containerDark: {
backgroundColor: "#0a0a0a",
},
center: {
justifyContent: "center",
alignItems: "center",
},
content: {
padding: 16,
paddingBottom: 32,
},
errorText: {
fontSize: 16,
color: "#666666",
},
label: {
fontSize: 14,
fontWeight: "600",
color: "#0a0a0a",
marginTop: 16,
marginBottom: 8,
},
labelDark: {
color: "#ffffff",
},
typeContainer: {
flexDirection: "row",
gap: 8,
},
typeOption: {
flex: 1,
flexDirection: "row",
alignItems: "center",
justifyContent: "center",
padding: 12,
borderRadius: 8,
backgroundColor: "#f5f5f5",
gap: 6,
},
typeOptionDark: {
backgroundColor: "#1a1a1a",
},
typeOptionSelected: {
backgroundColor: "#0a0a0a",
},
typeOptionSelectedDark: {
backgroundColor: "#ffffff",
},
typeLabel: {
fontSize: 13,
fontWeight: "500",
color: "#666666",
},
textDark: {
color: "#ffffff",
},
typeLabelSelected: {
color: "#ffffff",
},
typeLabelSelectedDark: {
color: "#0a0a0a",
},
input: {
backgroundColor: "#f5f5f5",
borderRadius: 8,
paddingHorizontal: 16,
paddingVertical: 12,
fontSize: 16,
color: "#0a0a0a",
},
inputDark: {
backgroundColor: "#1a1a1a",
color: "#ffffff",
},
hint: {
fontSize: 13,
color: "#666666",
marginTop: 6,
},
hintDark: {
color: "#888888",
},
sectionTitle: {
fontSize: 18,
fontWeight: "600",
color: "#0a0a0a",
marginTop: 32,
marginBottom: 8,
},
actions: {
marginTop: 32,
gap: 12,
},
testButton: {
flexDirection: "row",
alignItems: "center",
justifyContent: "center",
gap: 8,
padding: 16,
borderRadius: 12,
borderWidth: 1,
borderColor: "#e5e5e5",
},
testButtonDark: {
borderColor: "#333333",
},
testButtonText: {
fontSize: 16,
fontWeight: "600",
color: "#0a0a0a",
},
saveButton: {
alignItems: "center",
justifyContent: "center",
padding: 16,
borderRadius: 12,
backgroundColor: "#0a0a0a",
},
saveButtonDark: {
backgroundColor: "#ffffff",
},
saveButtonText: {
fontSize: 16,
fontWeight: "600",
color: "#ffffff",
},
saveButtonTextDark: {
color: "#0a0a0a",
},
deleteButton: {
flexDirection: "row",
alignItems: "center",
justifyContent: "center",
gap: 8,
padding: 16,
borderRadius: 12,
backgroundColor: "#fef2f2",
},
deleteButtonText: {
fontSize: 16,
fontWeight: "600",
color: "#ef4444",
},
})