feat(privacy+dist): telemetry consent gate + app store distribution prep (#4)

* fix(security): fail closed on biometric init error

H-03: setting isAuthenticated: true on initialization failure was a
security bypass — any crash during biometric setup granted full access.
Fail closed instead; user sees auth prompt on next open.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(security): use Crypto.randomUUID for connection IDs

H-04: Math.random() is not cryptographically random. Connection IDs are
used as SecureStore key suffixes; switch to expo-crypto randomUUID for
a secure source.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(deps): pin expo-crypto to ~15.0.9

15.0.10 does not exist on npm; ~15.0.9 is the latest stable in the 15.x series compatible with Expo SDK 54.

* feat: add OpenCode Connect coming-soon waitlist card

Adds a discoverable 'OpenCode Connect — Coming Soon' card to the
add-connection quick-connect screen. Users can enter their email and
tap 'Join Waitlist' to send a pre-filled mailto. No backend required.

* fix(cua): detect actual screen dimensions and fix JSON parsing

- Get real screen size via `wm size` instead of hardcoding 1080x2400;
  emulator is 1080x1920 so y-coordinates were systematically off
- Extract first JSON object via regex when model returns multiple objects
- Use AZURE_OPENAI_MODEL env var for deployment name (defaults gpt-5.4)
- Add AZURE_DEV_AI_* path for Azure AI Foundry endpoints

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(security): SHA-pin upload-google-play and sanitize notification bodies

M-02: Pin r0adkll/upload-google-play to commit SHA e738b9d (v1.1.5)
to prevent supply-chain hijack via tag mutation.

M-03: Sanitize all push notification bodies — strip control chars,
truncate to 200 chars. Prevents server-supplied strings (error messages,
file paths from permission patterns, session titles) from leaking
unbounded text into the OS notification drawer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat(privacy): add telemetry consent gate for Sentry crash reporting

Sentry was always-on, violating F-Droid anti-feature policy and user
trust norms. Now gated behind explicit opt-in:

- First-launch consent modal (TelemetryConsentModal) shows once on
  fresh install; user can Allow or Decline.
- Consent state persisted in expo-secure-store (survives restarts).
- Settings > Privacy section: crash reporting toggle + privacy policy link.
- initSentry() called only after consent granted — not on app start.

Closes #3 (partial)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat(config): add real icons and complete iOS/Android app.json config

- Add 1024×1024 app icon, 432×432 adaptive icon foreground, 200×200 splash
- iOS: push notification entitlement (aps-environment: production), speech/
  microphone/camera/photo usage descriptions for future features, disable
  ITSAppUsesNonExemptEncryption
- Android: adaptive icon with dark background (#0F172A), versionCode: 1
- expo-notifications plugin wired in app.json

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat(dist): add iOS CI workflow, README rewrite, CONTRIBUTING, and LICENSE

- publish-app-store.yml: EAS Build + TestFlight submission; runs on tag/release/
  workflow_dispatch; bumps ios.buildNumber from github.run_number
- README: full rewrite — features, install badges, connection guide, contributing
- CONTRIBUTING.md: contribution guide for OSS contributors
- LICENSE: MIT

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs(dist): add store listings, strategy, privacy policy, F-Droid/IzzyOnDroid templates

- distribution/strategy.md: monetization strategy (free client + opencode Cloud)
- distribution/play-listing.md: Google Play store copy (name, description, tags)
- distribution/app-store-listing.md: App Store listing copy
- distribution/privacy-policy.{md,html}: GDPR-compliant privacy policy
- distribution/PLAY_CONSOLE_SETUP.md: Play Console setup runbook
- distribution/ios-enrollment-runbook.md: Apple Developer Program enrollment steps
- distribution/SIGNING-KEY-FINGERPRINTS.md: keystore fingerprint for reproducible builds
- distribution/fdroid-submission/: F-Droid metadata template
- distribution/izzyondroid-submission/: IzzyOnDroid submission template
- distribution/whatsnew/: Play Store release notes (en-US)
- distribution/whatsnew-ios/: TestFlight release notes
- distribution/play-graphics/: Play Store screenshot placeholders
- distribution/app-store-graphics/: App Store screenshot placeholders

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(telemetry): handle SecureStore failure + Android back button

- add .catch() on loadTelemetryConsent() so SecureStore rejection
  shows the consent modal instead of blocking startup forever
- add onRequestClose={onDecline} to Modal so Android back button
  records the decline rather than silently dismissing
- fix catch block in telemetry.ts to not clobber _resolved when
  SecureStore read fails mid-session

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(ci): run gradlew clean to prevent stale modules.json duplicate

Sentry Gradle plugin writes modules.json to src/main/assets; cached
build intermediates contain an old copy → mergeReleaseAssets fails
with 'Duplicate resources'. Running clean before assembleRelease
clears the intermediate state.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(ci): remove android build output cache causing duplicate modules.json

Caching android/app/build/intermediates and android/app/.cxx causes
two issues:
1. Stale modules.json in intermediates → Duplicate resources error
2. .cxx CMake artifacts reference absolute paths → ninja clean fails

Keeping only Gradle distribution cache (~/.gradle) which is safe.
Expo prebuild regenerates android sources fresh each run anyway.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Den
2026-05-25 17:42:03 -07:00
committed by GitHub
parent 7ea41216c8
commit 2b9b571d6e
51 changed files with 3463 additions and 98 deletions

View File

@@ -0,0 +1,229 @@
/**
* First-launch consent modal for Sentry crash reporting.
*
* Shows once when the user hasn't yet made a consent decision.
* Matches the app's existing Settings screen visual conventions.
*/
import { View, Text, TouchableOpacity, StyleSheet, useColorScheme, Modal, Linking } from "react-native"
import { Ionicons } from "@expo/vector-icons"
interface Props {
visible: boolean
onAllow: () => void
onDecline: () => void
}
export function TelemetryConsentModal({ visible, onAllow, onDecline }: Props) {
const colorScheme = useColorScheme()
const isDark = colorScheme === "dark"
return (
<Modal visible={visible} transparent animationType="fade" statusBarTranslucent onRequestClose={onDecline}>
<View style={styles.overlay}>
<View style={[styles.card, isDark && styles.cardDark]}>
{/* Icon */}
<View style={[styles.iconWrap, isDark && styles.iconWrapDark]}>
<Ionicons name="bug-outline" size={40} color="#3b82f6" />
</View>
{/* Title */}
<Text style={[styles.title, isDark && styles.textDark]}>Help improve OpenCode?</Text>
{/* Body */}
<Text style={[styles.body, isDark && styles.bodyDark]}>
Share anonymous crash reports to help us find and fix bugs faster. No code, prompts,
or server addresses are ever included.
</Text>
{/* Detail bullets */}
<View style={styles.bullets}>
<BulletRow icon="checkmark-circle" text="Device model, OS version, app version" isDark={isDark} positive />
<BulletRow icon="checkmark-circle" text="Stack traces of crashes (no variable values)" isDark={isDark} positive />
<BulletRow icon="close-circle" text="Your code, prompts, or chat messages" isDark={isDark} positive={false} />
<BulletRow icon="close-circle" text="Server URLs or authentication tokens" isDark={isDark} positive={false} />
</View>
{/* Privacy policy link */}
<TouchableOpacity
onPress={() => Linking.openURL("https://www.vibebrowser.app/opencode-mobile/privacy")}
>
<Text style={styles.privacyLink}>Read our full privacy policy</Text>
</TouchableOpacity>
{/* Actions */}
<View style={styles.actions}>
<TouchableOpacity
style={[styles.btn, styles.btnDecline, isDark && styles.btnDeclineDark]}
onPress={onDecline}
accessibilityLabel="No thanks, decline crash reporting"
>
<Text style={[styles.btnDeclineText, isDark && styles.btnDeclineTextDark]}>No thanks</Text>
</TouchableOpacity>
<TouchableOpacity
style={[styles.btn, styles.btnAllow]}
onPress={onAllow}
accessibilityLabel="Allow anonymous crash reports"
>
<Text style={styles.btnAllowText}>Allow</Text>
</TouchableOpacity>
</View>
<Text style={[styles.footnote, isDark && styles.footnoteDark]}>
You can change this at any time in Settings → Privacy.
</Text>
</View>
</View>
</Modal>
)
}
function BulletRow({
icon,
text,
isDark,
positive,
}: {
icon: "checkmark-circle" | "close-circle"
text: string
isDark: boolean
positive: boolean
}) {
return (
<View style={styles.bulletRow}>
<Ionicons
name={icon}
size={18}
color={positive ? "#22c55e" : "#ef4444"}
style={styles.bulletIcon}
/>
<Text style={[styles.bulletText, isDark && styles.bodyDark]}>{text}</Text>
</View>
)
}
const styles = StyleSheet.create({
overlay: {
flex: 1,
backgroundColor: "rgba(0,0,0,0.6)",
justifyContent: "center",
alignItems: "center",
padding: 24,
},
card: {
backgroundColor: "#ffffff",
borderRadius: 20,
padding: 28,
width: "100%",
maxWidth: 440,
shadowColor: "#000",
shadowOffset: { width: 0, height: 8 },
shadowOpacity: 0.24,
shadowRadius: 16,
elevation: 10,
},
cardDark: {
backgroundColor: "#1a1a1a",
},
iconWrap: {
width: 72,
height: 72,
borderRadius: 18,
backgroundColor: "#eff6ff",
justifyContent: "center",
alignItems: "center",
alignSelf: "center",
marginBottom: 16,
},
iconWrapDark: {
backgroundColor: "#1e293b",
},
title: {
fontSize: 22,
fontWeight: "700",
color: "#0a0a0a",
textAlign: "center",
marginBottom: 12,
},
textDark: {
color: "#f8fafc",
},
body: {
fontSize: 15,
color: "#374151",
textAlign: "center",
lineHeight: 22,
marginBottom: 20,
},
bodyDark: {
color: "#94a3b8",
},
bullets: {
marginBottom: 16,
},
bulletRow: {
flexDirection: "row",
alignItems: "flex-start",
marginBottom: 8,
},
bulletIcon: {
marginTop: 2,
marginRight: 10,
flexShrink: 0,
},
bulletText: {
fontSize: 14,
color: "#374151",
flex: 1,
lineHeight: 20,
},
privacyLink: {
color: "#3b82f6",
fontSize: 14,
textAlign: "center",
marginBottom: 24,
textDecorationLine: "underline",
},
actions: {
flexDirection: "row",
gap: 12,
marginBottom: 16,
},
btn: {
flex: 1,
paddingVertical: 14,
borderRadius: 12,
alignItems: "center",
justifyContent: "center",
},
btnDecline: {
backgroundColor: "#f1f5f9",
},
btnDeclineDark: {
backgroundColor: "#2a2a2a",
},
btnDeclineText: {
color: "#374151",
fontWeight: "600",
fontSize: 16,
},
btnDeclineTextDark: {
color: "#94a3b8",
},
btnAllow: {
backgroundColor: "#3b82f6",
},
btnAllowText: {
color: "#ffffff",
fontWeight: "700",
fontSize: 16,
},
footnote: {
fontSize: 12,
color: "#9ca3af",
textAlign: "center",
},
footnoteDark: {
color: "#64748b",
},
})

80
src/lib/telemetry.ts Normal file
View File

@@ -0,0 +1,80 @@
/**
* Telemetry consent + initialisation gate.
*
* Wraps sentry.ts so that initSentry() is only called when the user has
* explicitly opted in. Consent state is persisted in expo-secure-store so
* it survives app restarts.
*
* Usage:
* import { loadTelemetryConsent, setTelemetryConsent, hasTelemetryConsent } from './telemetry'
*
* // On app start — call BEFORE trying to initialise Sentry.
* const state = await loadTelemetryConsent() // 'granted' | 'denied' | 'unknown'
* if (state === 'granted') initSentry()
*
* // After the user taps "Allow" in the consent modal:
* await setTelemetryConsent(true) // persists + calls initSentry() if not already done
*
* // Check in Settings screen:
* const current = hasTelemetryConsent() // boolean | null (null = not yet decided)
*/
import * as SecureStore from "expo-secure-store"
import { initSentry, sentryEnabled } from "./sentry"
const CONSENT_KEY = "opencode_telemetry_consent"
export type ConsentState = "granted" | "denied" | "unknown"
let _resolved: boolean | null = null // null = unknown, true = granted, false = denied
/**
* Load persisted consent from SecureStore.
* Returns 'unknown' if the user has never been asked.
*/
export async function loadTelemetryConsent(): Promise<ConsentState> {
try {
const stored = await SecureStore.getItemAsync(CONSENT_KEY)
if (stored === "granted") {
_resolved = true
return "granted"
}
if (stored === "denied") {
_resolved = false
return "denied"
}
// No stored value — first launch
_resolved = null
return "unknown"
} catch {
// SecureStore unavailable — don't clobber a previously resolved in-memory state.
// Return unknown so the caller can surface the modal.
return "unknown"
}
}
/**
* Returns the in-memory resolved state (set by loadTelemetryConsent or setTelemetryConsent).
* null = consent decision not yet loaded.
* true = granted.
* false = denied.
*/
export function hasTelemetryConsent(): boolean | null {
return _resolved
}
/**
* Persist the user's consent decision and, if granted and Sentry is not yet
* running, initialise it immediately.
*/
export async function setTelemetryConsent(granted: boolean): Promise<void> {
_resolved = granted
try {
await SecureStore.setItemAsync(CONSENT_KEY, granted ? "granted" : "denied")
} catch {
// Best-effort persist — in-memory state is still correct for this session.
}
if (granted && !sentryEnabled()) {
initSentry()
}
}

View File

@@ -71,7 +71,7 @@ export const useAuth = create<AuthState>((set, get) => ({
set({
error: "Failed to initialize authentication",
isLoading: false,
isAuthenticated: true, // Fail open for usability
isAuthenticated: false,
})
}
},

View File

@@ -1,5 +1,6 @@
import { create } from "zustand"
import * as SecureStore from "expo-secure-store"
import * as Crypto from "expo-crypto"
import type { ServerConnection, ConnectionType } from "../lib/types"
import { createClient, type Client, type Project } from "../lib/sdk"
import { addBreadcrumb } from "../lib/sentry"
@@ -43,7 +44,7 @@ interface ConnectionsState {
}
function generateId(): string {
return Math.random().toString(36).slice(2, 11)
return Crypto.randomUUID().replace(/-/g, "").slice(0, 16)
}
function buildClient(

View File

@@ -2,6 +2,10 @@ import { create } from "zustand"
import { useConnections } from "./connections"
import { useSessions } from "./sessions"
import { send as notify } from "../lib/notifications"
const MAX_NOTIF_BODY = 200
const sanitizeBody = (s: string | undefined, fallback: string): string =>
(s ? s.replace(/[\x00-\x1f\x7f]/g, " ").trim().slice(0, MAX_NOTIF_BODY) : "") || fallback
import { addBreadcrumb } from "../lib/sentry"
import type { Client, Part, Session, Message } from "../lib/sdk"
@@ -141,7 +145,7 @@ export const useEvents = create<EventsState>((set, get) => ({
notify({
category: "connection",
title: "Connection interrupted",
body: "Trying to reconnect to your server",
body: sanitizeBody(undefined, "Trying to reconnect to your server"),
sessionId: "",
dedupeKey: "sse-prolonged-disconnect",
dedupeCooldownMs: 60_000,
@@ -204,7 +208,7 @@ export const useEvents = create<EventsState>((set, get) => ({
notify({
category: "completed",
title: "Task completed",
body: match?.title || "Session finished processing",
body: sanitizeBody(match?.title, "Session finished processing"),
sessionId: sessionID,
})
}
@@ -271,7 +275,7 @@ export const useEvents = create<EventsState>((set, get) => ({
notify({
category: "errors",
title: "Session error",
body: error?.message || "Something went wrong",
body: sanitizeBody(error?.message, "Something went wrong"),
sessionId: sessionID,
})
break
@@ -291,7 +295,7 @@ export const useEvents = create<EventsState>((set, get) => ({
notify({
category: "permissions",
title: req.permission || "Permission requested",
body: req.patterns?.join(", ") || "A tool needs your approval",
body: sanitizeBody(req.patterns?.join(", "), "A tool needs your approval"),
sessionId: req.sessionID,
})
break
@@ -324,7 +328,7 @@ export const useEvents = create<EventsState>((set, get) => ({
notify({
category: "questions",
title: req.questions?.[0]?.header || "Input needed",
body: req.questions?.[0]?.question || "The assistant has a question",
body: sanitizeBody(req.questions?.[0]?.question, "The assistant has a question"),
sessionId: req.sessionID,
})
break