feat(privacy+dist): telemetry consent gate + app store distribution prep (#4)
* fix(security): fail closed on biometric init error H-03: setting isAuthenticated: true on initialization failure was a security bypass — any crash during biometric setup granted full access. Fail closed instead; user sees auth prompt on next open. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(security): use Crypto.randomUUID for connection IDs H-04: Math.random() is not cryptographically random. Connection IDs are used as SecureStore key suffixes; switch to expo-crypto randomUUID for a secure source. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(deps): pin expo-crypto to ~15.0.9 15.0.10 does not exist on npm; ~15.0.9 is the latest stable in the 15.x series compatible with Expo SDK 54. * feat: add OpenCode Connect coming-soon waitlist card Adds a discoverable 'OpenCode Connect — Coming Soon' card to the add-connection quick-connect screen. Users can enter their email and tap 'Join Waitlist' to send a pre-filled mailto. No backend required. * fix(cua): detect actual screen dimensions and fix JSON parsing - Get real screen size via `wm size` instead of hardcoding 1080x2400; emulator is 1080x1920 so y-coordinates were systematically off - Extract first JSON object via regex when model returns multiple objects - Use AZURE_OPENAI_MODEL env var for deployment name (defaults gpt-5.4) - Add AZURE_DEV_AI_* path for Azure AI Foundry endpoints Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(security): SHA-pin upload-google-play and sanitize notification bodies M-02: Pin r0adkll/upload-google-play to commit SHA e738b9d (v1.1.5) to prevent supply-chain hijack via tag mutation. M-03: Sanitize all push notification bodies — strip control chars, truncate to 200 chars. Prevents server-supplied strings (error messages, file paths from permission patterns, session titles) from leaking unbounded text into the OS notification drawer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(privacy): add telemetry consent gate for Sentry crash reporting Sentry was always-on, violating F-Droid anti-feature policy and user trust norms. Now gated behind explicit opt-in: - First-launch consent modal (TelemetryConsentModal) shows once on fresh install; user can Allow or Decline. - Consent state persisted in expo-secure-store (survives restarts). - Settings > Privacy section: crash reporting toggle + privacy policy link. - initSentry() called only after consent granted — not on app start. Closes #3 (partial) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(config): add real icons and complete iOS/Android app.json config - Add 1024×1024 app icon, 432×432 adaptive icon foreground, 200×200 splash - iOS: push notification entitlement (aps-environment: production), speech/ microphone/camera/photo usage descriptions for future features, disable ITSAppUsesNonExemptEncryption - Android: adaptive icon with dark background (#0F172A), versionCode: 1 - expo-notifications plugin wired in app.json Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(dist): add iOS CI workflow, README rewrite, CONTRIBUTING, and LICENSE - publish-app-store.yml: EAS Build + TestFlight submission; runs on tag/release/ workflow_dispatch; bumps ios.buildNumber from github.run_number - README: full rewrite — features, install badges, connection guide, contributing - CONTRIBUTING.md: contribution guide for OSS contributors - LICENSE: MIT Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs(dist): add store listings, strategy, privacy policy, F-Droid/IzzyOnDroid templates - distribution/strategy.md: monetization strategy (free client + opencode Cloud) - distribution/play-listing.md: Google Play store copy (name, description, tags) - distribution/app-store-listing.md: App Store listing copy - distribution/privacy-policy.{md,html}: GDPR-compliant privacy policy - distribution/PLAY_CONSOLE_SETUP.md: Play Console setup runbook - distribution/ios-enrollment-runbook.md: Apple Developer Program enrollment steps - distribution/SIGNING-KEY-FINGERPRINTS.md: keystore fingerprint for reproducible builds - distribution/fdroid-submission/: F-Droid metadata template - distribution/izzyondroid-submission/: IzzyOnDroid submission template - distribution/whatsnew/: Play Store release notes (en-US) - distribution/whatsnew-ios/: TestFlight release notes - distribution/play-graphics/: Play Store screenshot placeholders - distribution/app-store-graphics/: App Store screenshot placeholders Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(telemetry): handle SecureStore failure + Android back button - add .catch() on loadTelemetryConsent() so SecureStore rejection shows the consent modal instead of blocking startup forever - add onRequestClose={onDecline} to Modal so Android back button records the decline rather than silently dismissing - fix catch block in telemetry.ts to not clobber _resolved when SecureStore read fails mid-session Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(ci): run gradlew clean to prevent stale modules.json duplicate Sentry Gradle plugin writes modules.json to src/main/assets; cached build intermediates contain an old copy → mergeReleaseAssets fails with 'Duplicate resources'. Running clean before assembleRelease clears the intermediate state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(ci): remove android build output cache causing duplicate modules.json Caching android/app/build/intermediates and android/app/.cxx causes two issues: 1. Stale modules.json in intermediates → Duplicate resources error 2. .cxx CMake artifacts reference absolute paths → ninja clean fails Keeping only Gradle distribution cache (~/.gradle) which is safe. Expo prebuild regenerates android sources fresh each run anyway. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Den
174
.github/workflows/publish-app-store.yml
vendored
Normal file
174
.github/workflows/publish-app-store.yml
vendored
Normal file
@@ -0,0 +1,174 @@
|
||||
# STATUS: Validated structure — awaiting Apple Developer Program enrollment approval.
|
||||
# Once enrollment is approved, complete these steps and this workflow is production-ready:
|
||||
#
|
||||
# REMAINING GAPS (must complete before first run):
|
||||
# 1. Update eas.json: replace REPLACE_WITH_APP_STORE_CONNECT_APP_ID and REPLACE_WITH_APPLE_TEAM_ID
|
||||
# (see eas.json.README.md for exact click paths in App Store Connect)
|
||||
# 2. Add GitHub secrets (Settings > Secrets and variables > Actions):
|
||||
# EAS_TOKEN Expo access token (expo.dev > Account > Access Tokens)
|
||||
# APPLE_APP_STORE_CONNECT_API_KEY_ID Key ID from App Store Connect > Users & Access > Integrations > App Store Connect API
|
||||
# APPLE_APP_STORE_CONNECT_ISSUER_ID Issuer ID from same page
|
||||
# APPLE_APP_STORE_CONNECT_API_KEY base64-encoded .p8 file (download at key creation — one time only)
|
||||
# 3. Run `eas login` locally and `eas build:configure` on first run to let EAS set up signing
|
||||
# 4. Manually upload first build to App Store Connect (required once to create the app record)
|
||||
#
|
||||
# OPTIONAL secrets (crash reporting):
|
||||
# EXPO_PUBLIC_SENTRY_DSN SENTRY_AUTH_TOKEN SENTRY_ORG SENTRY_PROJECT
|
||||
#
|
||||
# Build strategy: EAS Build (Expo Application Services)
|
||||
# - No Mac runner needed; Expo hosts macOS workers with managed certificates.
|
||||
# - Cost: free tier (30 builds/month); upgrade to $19/month for unlimited/priority queue.
|
||||
# - See distribution/ios-enrollment-runbook.md for full enrollment steps.
|
||||
# - See eas.json.README.md for placeholder fill-in instructions.
|
||||
# - Alternative (self-hosted Mac runner): see commented section at bottom of this file.
|
||||
|
||||
name: Publish to App Store (TestFlight)
|
||||
|
||||
on:
|
||||
release:
|
||||
types: [published]
|
||||
push:
|
||||
tags: ["v*"]
|
||||
workflow_dispatch:
|
||||
|
||||
jobs:
|
||||
publish-ios:
|
||||
runs-on: ubuntu-latest
|
||||
env:
|
||||
EXPO_PUBLIC_SENTRY_DSN: ${{ secrets.EXPO_PUBLIC_SENTRY_DSN }}
|
||||
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
|
||||
SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
|
||||
SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }}
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
|
||||
- uses: actions/setup-node@v4
|
||||
with:
|
||||
node-version: 20
|
||||
cache: npm
|
||||
|
||||
# Install EAS CLI globally. Pin to a recent stable version.
|
||||
- name: Install EAS CLI
|
||||
run: npm install -g eas-cli@13
|
||||
|
||||
- name: Install dependencies
|
||||
run: npm install --legacy-peer-deps
|
||||
|
||||
# Bump ios.buildNumber to match github.run_number (monotonically increasing).
|
||||
# App Store Connect rejects duplicate build numbers for the same version string.
|
||||
- name: Bump ios.buildNumber in app.json
|
||||
run: |
|
||||
node -e "
|
||||
const f = 'app.json';
|
||||
const j = require('./' + f);
|
||||
j.expo.ios = j.expo.ios || {};
|
||||
j.expo.ios.buildNumber = String(${{ github.run_number }});
|
||||
require('fs').writeFileSync(f, JSON.stringify(j, null, 2) + '\n');
|
||||
"
|
||||
echo "buildNumber now: $(node -p "require('./app.json').expo.ios.buildNumber")"
|
||||
|
||||
# EAS Build: builds the IPA in Expo's cloud (macOS workers managed by Expo).
|
||||
# --non-interactive: no prompts, suitable for CI.
|
||||
# --platform ios: iOS only (Android is handled by publish-play-store.yml).
|
||||
# --profile production: uses the "production" profile in eas.json (created below if missing).
|
||||
- name: Build IPA via EAS
|
||||
env:
|
||||
EXPO_TOKEN: ${{ secrets.EAS_TOKEN }}
|
||||
APPLE_APP_STORE_CONNECT_API_KEY_ID: ${{ secrets.APPLE_APP_STORE_CONNECT_API_KEY_ID }}
|
||||
APPLE_APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APPLE_APP_STORE_CONNECT_ISSUER_ID }}
|
||||
APPLE_APP_STORE_CONNECT_API_KEY: ${{ secrets.APPLE_APP_STORE_CONNECT_API_KEY }}
|
||||
run: |
|
||||
eas build \
|
||||
--platform ios \
|
||||
--profile production \
|
||||
--non-interactive \
|
||||
--no-wait \
|
||||
--json \
|
||||
| tee eas-build-output.json
|
||||
BUILD_ID=$(cat eas-build-output.json | node -e "const d=require('fs').readFileSync('/dev/stdin','utf8');console.log(JSON.parse(d).id)")
|
||||
echo "EAS_BUILD_ID=$BUILD_ID" >> $GITHUB_ENV
|
||||
echo "Build ID: $BUILD_ID"
|
||||
|
||||
# Wait for the EAS build to complete (iOS builds typically take 15–25 minutes).
|
||||
- name: Wait for EAS build
|
||||
env:
|
||||
EXPO_TOKEN: ${{ secrets.EAS_TOKEN }}
|
||||
run: |
|
||||
echo "Waiting for build $EAS_BUILD_ID to complete..."
|
||||
eas build:view "$EAS_BUILD_ID" --json --wait
|
||||
echo "Build complete."
|
||||
|
||||
# Submit to TestFlight via EAS Submit. Uses the same App Store Connect API key.
|
||||
# --latest: picks the most recent finished build for this app + platform.
|
||||
- name: Submit to TestFlight via EAS Submit
|
||||
env:
|
||||
EXPO_TOKEN: ${{ secrets.EAS_TOKEN }}
|
||||
APPLE_APP_STORE_CONNECT_API_KEY_ID: ${{ secrets.APPLE_APP_STORE_CONNECT_API_KEY_ID }}
|
||||
APPLE_APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APPLE_APP_STORE_CONNECT_ISSUER_ID }}
|
||||
APPLE_APP_STORE_CONNECT_API_KEY: ${{ secrets.APPLE_APP_STORE_CONNECT_API_KEY }}
|
||||
run: |
|
||||
eas submit \
|
||||
--platform ios \
|
||||
--id "$EAS_BUILD_ID" \
|
||||
--non-interactive
|
||||
|
||||
# Upload release notes to TestFlight (what's new text for testers).
|
||||
# NOTE: EAS Submit does not yet support whatsNew natively; use fastlane pilot
|
||||
# or App Store Connect API directly if per-build release notes are needed.
|
||||
- name: Upload TestFlight release notes (informational)
|
||||
run: |
|
||||
echo "TestFlight release notes for this build:"
|
||||
cat distribution/whatsnew-ios/release-notes-en-US.txt
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# ALTERNATIVE: Self-hosted Mac runner (macbook13-pro at 100.68.120.26)
|
||||
# ---------------------------------------------------------------------------
|
||||
# To use the Mac mini instead of EAS Build:
|
||||
# 1. SSH to macbook13-pro and set up GitHub self-hosted runner:
|
||||
# https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/adding-self-hosted-runners
|
||||
# 2. Change "runs-on: ubuntu-latest" above to "runs-on: self-hosted"
|
||||
# and add label "macos" for clarity.
|
||||
# 3. Replace the EAS Build + Submit steps with:
|
||||
#
|
||||
# - name: Install CocoaPods
|
||||
# run: sudo gem install cocoapods
|
||||
#
|
||||
# - name: Expo prebuild (iOS)
|
||||
# run: npx expo prebuild --platform ios --no-install
|
||||
#
|
||||
# - name: Install CocoaPods dependencies
|
||||
# working-directory: ios
|
||||
# run: pod install
|
||||
#
|
||||
# - name: Build IPA
|
||||
# run: |
|
||||
# xcodebuild -workspace ios/opencodemobile.xcworkspace \
|
||||
# -scheme opencodemobile \
|
||||
# -sdk iphoneos \
|
||||
# -configuration Release \
|
||||
# -archivePath $RUNNER_TEMP/opencodemobile.xcarchive \
|
||||
# archive \
|
||||
# CODE_SIGN_STYLE=Manual \
|
||||
# DEVELOPMENT_TEAM=${{ secrets.APPLE_TEAM_ID }} \
|
||||
# CODE_SIGN_IDENTITY="Apple Distribution" \
|
||||
# PROVISIONING_PROFILE_SPECIFIER="${{ secrets.IOS_PROVISIONING_PROFILE_NAME }}"
|
||||
#
|
||||
# - name: Export IPA
|
||||
# run: |
|
||||
# xcodebuild -exportArchive \
|
||||
# -archivePath $RUNNER_TEMP/opencodemobile.xcarchive \
|
||||
# -exportOptionsPlist ios/ExportOptions.plist \
|
||||
# -exportPath $RUNNER_TEMP/export
|
||||
#
|
||||
# - name: Upload to TestFlight (xcrun altool / notarytool)
|
||||
# run: |
|
||||
# xcrun altool --upload-app \
|
||||
# -f "$RUNNER_TEMP/export/opencodemobile.ipa" \
|
||||
# --type ios \
|
||||
# --apiKey "${{ secrets.APPLE_APP_STORE_CONNECT_API_KEY_ID }}" \
|
||||
# --apiIssuer "${{ secrets.APPLE_APP_STORE_CONNECT_ISSUER_ID }}"
|
||||
#
|
||||
# Self-hosted runner cost: $0 compute (your hardware), but requires maintaining
|
||||
# a macOS machine with Xcode, certificates, and provisioning profiles.
|
||||
# EAS Build is strongly recommended for the first release.
|
||||
Reference in New Issue
Block a user