From 1c242e6a213af5cef43d6babc29739c272836f98 Mon Sep 17 00:00:00 2001
From: engineer <engineer@opencode.ai>
Date: Mon, 1 Jun 2026 14:37:32 -0700
Subject: [PATCH] fix(ci): use latest fdroidserver for F-Droid publish

Pinning fdroidserver 2.4.4 hit androguard parse bugs on modern aapt2 APKs
(4.1+: NoOverwriteDict.append; 4.0.x: 'res1 must be zero!'). Upgrade to latest
fdroidserver which ships a compatible androguard.
---
 .github/workflows/publish-fdroid.yml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/publish-fdroid.yml b/.github/workflows/publish-fdroid.yml
index ea144b3..47be315 100644
--- a/.github/workflows/publish-fdroid.yml
+++ b/.github/workflows/publish-fdroid.yml
@@ -69,10 +69,11 @@ jobs:
         run: ./gradlew assembleRelease
 
       - name: Install fdroidserver
-        # Pin androguard < 4.1: 4.1+ regressed APK signature parsing
-        # ('NoOverwriteDict' object has no attribute 'append') and breaks
-        # `fdroid update` with fdroidserver 2.4.4.
-        run: pip install "fdroidserver==2.4.4" "androguard>=4.0,<4.1"
+        # Use latest fdroidserver (+ its tested androguard). Pinning fdroidserver
+        # 2.4.4 hit androguard parse bugs on modern aapt2 APKs: 4.1+ crashes with
+        # "'NoOverwriteDict' object has no attribute 'append'", 4.0.x with
+        # "res1 must be zero!". Latest fdroidserver ships a compatible androguard.
+        run: pip install --upgrade fdroidserver
 
       - name: Setup F-Droid repo
         id: fdroid-setup